LGTM. On Tue, Nov 18, 2008 at 11:53 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Kasper Lund, > > Description: > Ensure that external symbols have hash codes. > > Please review this at http://codereview.chromium.org/11443 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/heap.cc > > > Index: src/heap.cc > =================================================================== > --- src/heap.cc (revision 778) > +++ src/heap.cc (working copy) > @@ -2142,6 +2142,8 @@ > // Patch the resource pointer of the result. > ExternalTwoByteString* result = ExternalTwoByteString::cast(obj); > result->set_resource(resource); > + // Force hash code to be computed. > + result->Hash(); > ASSERT(result->IsEqualTo(string)); > return result; > } > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
