LGTM, but please submit as an individual change to be able to isolate in benchmark runs.
-Ivan http://codereview.chromium.org/11276/diff/1/2 File src/stub-cache-ia32.cc (right): http://codereview.chromium.org/11276/diff/1/2#newcode429 Line 429: __ mov(scratch, FieldOperand(receiver_reg, JSObject::kPropertiesOffset)); Moving the load of the properties pointer down here only has a potential performance impact when this store also happens to have a transition. This should be negligible, but we should verify this with a benchmark run. http://codereview.chromium.org/11276 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
