Lint issues fixed and (after several failed attempts) regression test added. Thanks!
On Wed, Nov 19, 2008 at 3:53 PM, Kasper Lund <[EMAIL PROTECTED]> wrote: > > LGTM, but I would feel safer with a regression test case even though > it may be difficult to construct one. There seems to be a pretty long > line in the ARM version - does it lint after your changes? > > On Wed, Nov 19, 2008 at 3:46 PM, <[EMAIL PROTECTED]> wrote: >> >> Reviewers: Kasper Lund, >> >> Description: >> When probing a dictionary backing storage in generated code, make sure >> not to return functions that have not been loaded. >> >> This fixes crashes on expedia.com: >> >> http://code.google.com/p/chromium/issues/detail?id=4526 >> >> Please review this at http://codereview.chromium.org/11272 >> >> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ >> >> Affected files: >> M src/ic-arm.cc >> M src/ic-ia32.cc >> >> >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
