OK. I'll fix this next week sometime. On Thu, Nov 20, 2008 at 10:47 AM, Kasper Lund <[EMAIL PROTECTED]> wrote:
> LGTM. > > On Thu, Nov 20, 2008 at 10:47 AM, <[EMAIL PROTECTED]> wrote: > > Reviewers: Kasper Lund, William Hesse, > > > > Description: > > Disable map collection since there is a bug in it somewhere. Leave in > > the code so we can work on it. > > > > Please review this at http://codereview.chromium.org/11806 > > > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > > > Affected files: > > M src/flag-definitions.h > > > > > > Index: src/flag-definitions.h > > =================================================================== > > --- src/flag-definitions.h (revision 784) > > +++ src/flag-definitions.h (working copy) > > @@ -151,7 +151,7 @@ > > DEFINE_int(gc_interval, -1, "garbage collect after <n> allocations") > > DEFINE_bool(trace_gc, false, > > "print one trace line following each garbage collection") > > -DEFINE_bool(collect_maps, true, > > +DEFINE_bool(collect_maps, false, > > "garbage collect maps from which no objects can be reached") > > > > // ic.cc > > > > > > > -- We can IMAGINE what is not --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
