LGTM
http://codereview.chromium.org/11319/diff/1/6 File src/assembler-re2k.cc (right): http://codereview.chromium.org/11319/diff/1/6#newcode85 Line 85: void Re2kAssembler::SetCurrentPositionFromRegister(int index) { You have "Write..To" but "Set..From". Wouldn't it be more nicely symmetric if it was "Read...From"? http://codereview.chromium.org/11319/diff/1/11 File src/jsregexp.cc (right): http://codereview.chromium.org/11319/diff/1/11#newcode1701 Line 1701: int stack_pointer_register = compiler->AllocateRegister(); You never free a register again. Would it be possible to free registers, and perhaps reuse them? http://codereview.chromium.org/11319 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
