LGTM, see comments.
http://codereview.chromium.org/11547/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/11547/diff/1/2#newcode82 Line 82: return i::SmartPointer<char>(str ? i::StrDup(str) : str); The fix looks good to me, but it does not resolve the confusion between i::StrDup and i::OS::StrDup. Please file a bug. http://codereview.chromium.org/11547 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
