Oops, thanks. LGTM.
On Mon, Nov 24, 2008 at 12:24 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Erik Corry, > > Message: > Review please. > > Description: > Writing in non-CAN_READ_UNALIGNED mode works (and compiles). > > Please review this at http://codereview.chromium.org/11599 > > Affected files: > M regexp2000/src/utils.h > > > Index: regexp2000/src/utils.h > diff --git a/regexp2000/src/utils.h b/regexp2000/src/utils.h > index > e3e000fcf28f3c2c17a281c9601ab8fae73e316c..a1e14f9e12ffbf9bf1181f5aec7ef27ce5e41b75 > 100644 > --- a/regexp2000/src/utils.h > +++ b/regexp2000/src/utils.h > @@ -538,7 +538,6 @@ static inline void Store16(byte* pc, uint16_t value) { > #ifdef CAN_READ_UNALIGNED > *reinterpret_cast<uint16_t*>(pc) = value; > #else > - uint16_t word; > pc[1] = value; > pc[0] = value >> 8; > #endif > @@ -549,12 +548,10 @@ static inline void Store32(byte* pc, uint32_t value) > { > #ifdef CAN_READ_UNALIGNED > *reinterpret_cast<uint32_t*>(pc) = value; > #else > - uint32_t word; > pc[3] = value; > pc[2] = value >> 8; > pc[1] = value >> 16; > pc[0] = value >> 24; > - return word; > #endif > } > > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
