Lgtm.
http://codereview.chromium.org/12406/diff/1/7 File src/interpreter-irregexp.cc (right): http://codereview.chromium.org/12406/diff/1/7#newcode45 Line 45: static bool BackRefMatchesNoCase(int from, If we were concerned about performance we could consider comparing compares old_char and new_char before canonicalization, as an expected fast case. http://codereview.chromium.org/12406/diff/1/10 File src/jsregexp.cc (right): http://codereview.chromium.org/12406/diff/1/10#newcode1477 Line 1477: if (!compiler->is_case_independent()) { Why negate the condition? http://codereview.chromium.org/12406 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
