Reviewers: Lasse Reichstein,

Description:
Fixed Visual Studio build with snapshot when V8 is checked out in a
directory with spaces in the path.

Please review this at http://codereview.chromium.org/12428

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     tools/visual_studio/v8_snapshot.vcproj


Index: tools/visual_studio/v8_snapshot.vcproj
===================================================================
--- tools/visual_studio/v8_snapshot.vcproj      (revision 829)
+++ tools/visual_studio/v8_snapshot.vcproj      (working copy)
@@ -160,7 +160,7 @@
                                <Tool
                                        Name="VCCustomBuildTool"
                                        Description="Building snapshot..."
-                                       
CommandLine="$(OutDir)\v8_mksnapshot.exe  
$(IntDir)\DerivedSources\snapshot.cc&#x0D;&#x0A;"
+                                       
CommandLine="&quot;$(OutDir)\v8_mksnapshot.exe&quot;  
&quot;$(IntDir)\DerivedSources\snapshot.cc&quot;&#x0D;&#x0A;"
                                        
AdditionalDependencies="$(OutDir)\v8_mksnapshot.exe"
                                        
Outputs="$(IntDir)\DerivedSources\snapshot.cc"
                                />
@@ -171,7 +171,7 @@
                                <Tool
                                        Name="VCCustomBuildTool"
                                        Description="Building snapshot..."
-                                       
CommandLine="$(OutDir)\v8_mksnapshot.exe  
$(IntDir)\DerivedSources\snapshot.cc&#x0D;&#x0A;"
+                                       
CommandLine="&quot;$(OutDir)\v8_mksnapshot.exe&quot;  
&quot;$(IntDir)\DerivedSources\snapshot.cc&quot;&#x0D;&#x0A;"
                                        
AdditionalDependencies="$(OutDir)\v8_mksnapshot.exe"
                                        
Outputs="$(IntDir)\DerivedSources\snapshot.cc"
                                />



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to