LGTM On Tue, Nov 25, 2008 at 3:22 PM, <[EMAIL PROTECTED]> wrote:
> Reviewers: Erik Corry, > > Description: > Made irregexp flags available in release mode > > Please review this at http://codereview.chromium.org/12636 > > Affected files: > M src/flag-definitions.h > > > Index: src/flag-definitions.h > diff --git a/src/flag-definitions.h b/src/flag-definitions.h > index > 59926eaa7f471a604ed183b64d7f9d788ace358c..9ec18b794eba56b6b824077acd330d82b2daacc3 > 100644 > --- a/src/flag-definitions.h > +++ b/src/flag-definitions.h > @@ -199,6 +199,13 @@ DEFINE_bool(usage_computation, true, "compute variable > usage counts") > DEFINE_bool(preemption, false, > "activate a 100ms timer that switches between V8 threads") > > +// irregexp > +DEFINE_bool(irregexp, false, "new regular expression code") > +DEFINE_bool(trace_regexps, false, "trace Irregexp execution") > +DEFINE_bool(trace_regexp_bytecodes, false, "trace Irregexp bytecode > executon") > +DEFINE_bool(attempt_case_independent, false, "attempt to run Irregexp case > independent") > +DEFINE_bool(irregexp_native, false, "use native code Irregexp > implementation (IA32 only)") > + > // Testing flags test/cctest/test-{flags,api,serialization}.cc > DEFINE_bool(testing_bool_flag, true, "testing_bool_flag") > DEFINE_int(testing_int_flag, 13, "testing_int_flag") > @@ -289,12 +296,6 @@ DEFINE_bool(collect_heap_spill_statistics, false, > "report heap spill statistics along with heap_stats " > "(requires heap_stats)") > > -DEFINE_bool(irregexp, false, "new regular expression code") > -DEFINE_bool(trace_regexps, false, "trace Irregexp execution") > -DEFINE_bool(trace_regexp_bytecodes, false, "trace Irregexp bytecode > executon") > -DEFINE_bool(attempt_case_independent, false, "attempt to run Irregexp case > independent") > -DEFINE_bool(irregexp_native, false, "use native code Irregexp > implementation (IA32 only)") > - > // > // Logging and profiling only flags > // > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
