Please fix the problems with this change. I have not been watching the branch while you guys were developing, but now that it is in bleeding_edge you need to keep this clean.
Thanks, -Ivan http://codereview.chromium.org/12635/diff/1/3 File src/regexp-macro-assembler-ia32.h (right): http://codereview.chromium.org/12635/diff/1/3#newcode31 Line 31: #if !(defined(ARM) || defined(__arm__) || defined(__thumb__)) This is just plain wrong. There should never be any reason to check for ARM in a ia32 specific file. This indicates that there is a problem with your abstractions or include files. http://codereview.chromium.org/12635/diff/1/5 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/12635/diff/1/5#newcode723 Line 723: #if !(defined(ARM) || defined(__arm__) || defined(__thumb__)) It should be sufficient to only test for "defined(ARM)" in general. __arm__ and __thumb__ should only be tested if the code has to be different for the actual ARM cpu running (Simulator, Thumb or general ARM). http://codereview.chromium.org/12635 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
