I guess it LGTM. It would be nice to see the changes to unibrow, rather than to the generated files in cases like this.
http://codereview.chromium.org/12638/diff/1/4 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/12638/diff/1/4#newcode1090 Line 1090: if (next_block + i == 880) I don't understand this change. http://codereview.chromium.org/12638 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
