LGTM But we should figure out what it is that makes Mac different on pure IA32 code.
On Tue, Nov 25, 2008 at 4:44 PM, <[EMAIL PROTECTED]> wrote: > Reviewers: Lasse Reichstein, > > Message: > Post-facto code review. > > Description: > Marked MacroAssemblerIA32Simple as expected to fail on mac. > > Please review this at http://codereview.chromium.org/12639 > > Affected files: > M test/cctest/cctest.status > > > Index: test/cctest/cctest.status > diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status > index > fc7cd6a66ddad73c2ee01893dcaef9c69b9282a2..5aaca694621bb39c17f9dd655205cfa94b274ad3 > 100644 > --- a/test/cctest/cctest.status > +++ b/test/cctest/cctest.status > @@ -37,3 +37,7 @@ test-serialize: SKIP > > # BUG(113): Test seems flaky on ARM. > test-spaces/LargeObjectSpace: PASS || FAIL > + > +[ $system == macos ] > + > +test-regexp/MacroAssemblerIA32Simple: FAIL > > > -- Lasse R.H. Nielsen [EMAIL PROTECTED] 'Faith without judgement merely degrades the spirit divine' --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
