No extra include file any more. A few more "#if defined(ARM)" fixed.


http://codereview.chromium.org/12469/diff/22/202
File src/execution.cc (right):

http://codereview.chromium.org/12469/diff/22/202#newcode35
Line 35: #if defined(ARM)
On 2008/11/26 10:05:59, Kevin Millikin wrote:
> #ifdef ARM

Good catch!

http://codereview.chromium.org/12469/diff/22/204
File src/jsregexp.cc (right):

http://codereview.chromium.org/12469/diff/22/204#newcode46
Line 46: #include "regexp-macro-assembler-native.h"
It's gone.
It was used in only two places (jsregexp.cc and test-regexp.cc). The
includes from the native.h-file are now inlined in these two places.

http://codereview.chromium.org/12469/diff/22/206
File src/regexp-macro-assembler-arm.cc (right):

http://codereview.chromium.org/12469/diff/22/206#newcode39
Line 39: : RegExpMacroAssemblerIrregexp(NULL) {}
I think UNIMPLEMENTED is better. UNREACHABLE is a debug-only check.

http://codereview.chromium.org/12469/diff/22/210
File src/regexp-macro-assembler-native.h (right):

http://codereview.chromium.org/12469/diff/22/210#newcode39
Line 39: typedef RegExpMacroAssemblerARM RegExpMacroAssemblerImpl;
It's gone.

http://codereview.chromium.org/12469

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to