On Thu, Nov 27, 2008 at 7:49 AM, <[EMAIL PROTECTED]> wrote: > Lgtm > > > http://codereview.chromium.org/12473/diff/1/4 > File src/jsregexp.cc (right): > > http://codereview.chromium.org/12473/diff/1/4#newcode476 > Line 476: //PrintF("\n\nSubject string: '%s'\n\n", > *(two_byte_subject->ToCString())); > Either comment it back in or remove it.
Put back in (this was an accidental change). > > > http://codereview.chromium.org/12473/diff/1/3 > File src/jsregexp.h (right): > > http://codereview.chromium.org/12473/diff/1/3#newcode745 > Line 745: explicit Analysis(bool case_independent) > We're somewhat inconsistent in what we call this: case_independent, > ignore_case, etc. We should settle on just one and I vote for > ignore_case. Done. > > > http://codereview.chromium.org/12473 > I also added a new flag: --disable-jscre This flag is useful for testing where you want to be sure that you are using Irregexp. -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
