On Thu, Nov 27, 2008 at 10:26 AM, <[EMAIL PROTECTED]> wrote: > LGTM. > Good catch. That one can't have been easy! > > > http://codereview.chromium.org/10984/diff/1/3 > File src/regexp-macro-assembler-ia32.h (right): > > http://codereview.chromium.org/10984/diff/1/3#newcode91 > Line 91: static const int kBackup_ebx = sizeof(uint32_t); > I'm wondering whether sizeof(uint32_t) should be replaced by > kPointerSize instead.
I wondered about that too, but it wouldn't be IA32 any more if the registers weren't 32 bits wide, so it seems like the right thing. > > > http://codereview.chromium.org/10984 > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
