Reviewers: Dean McNamee,

Message:
Though the v8 contributor wiki says to send a patch to the mailing list,
running gcl seems to have picked up the appropriate mailing list.  So
please let me know if I should send this some other way.

(For those unfamiliar with this code, you should know that I've changed
this already on the Chrome side:
http://src.chromium.org/viewvc/chrome?view=rev&revision=5880
In particular, note that this file now has an adapter function to
convert from the wchar_t currently used by v8 to the ASCII expected by
Chrome:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/chromium_bridge_impl.cc?r1=5880&r2=5879&pathrev=5880
)

Description:
Use char instead of wchar_t for counter names.

Counters should be ASCII anyway, and wchar_t is four bytes per character
on non-Windows platforms.


Please review this at http://codereview.chromium.org/13011

SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/

Affected files:
   M     include/v8.h
   M     src/counters.h
   M     src/d8.h
   M     src/d8.cc
   M     src/v8-counters.cc



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to