lgtm On Mon, Dec 1, 2008 at 8:53 AM, <[EMAIL PROTECTED]> wrote: > Reviewers: Christian Plesner Hansen, > > Description: > Remove a couple of instances of wchar_t after counters change. > > > Please review this at http://codereview.chromium.org/12820 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/d8.cc > M test/cctest/test-serialize.cc > > > Index: test/cctest/test-serialize.cc > =================================================================== > --- test/cctest/test-serialize.cc (revision 870) > +++ test/cctest/test-serialize.cc (working copy) > @@ -44,12 +44,12 @@ > > static int local_counters[256]; > static int counter_count = 0; > -static std::map<std::wstring, int> counter_table; > +static std::map<std::string, int> counter_table; > > > // Callback receiver to track counters in test. > -static int* counter_function(const wchar_t* name) { > - std::wstring counter(name); > +static int* counter_function(const char* name) { > + std::string counter(name); > if (counter_table.find(counter) == counter_table.end()) { > local_counters[counter_count] = 0; > counter_table[counter] = counter_count++; > Index: src/d8.cc > =================================================================== > --- src/d8.cc (revision 871) > +++ src/d8.cc (working copy) > @@ -286,7 +286,7 @@ > i != counter_map_.end(); > i++) { > Counter* counter = (*i).second; > - ::printf("| %-38ls | %8i |\n", counter->name(), counter->value()); > + ::printf("| %-38s | %8i |\n", counter->name(), counter->value()); > } > ::printf("+----------------------------------------+----------+\n"); > } > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
