LGTM.
http://codereview.chromium.org/13014/diff/1/5 File src/jsregexp.h (right): http://codereview.chromium.org/13014/diff/1/5#newcode447 Line 447: enum TriBool { Not really a better name. Not that I can think of one that is, but TriBool is simply wrong (either it's three or it's a bool). http://codereview.chromium.org/13014/diff/1/6 File test/cctest/test-regexp.cc (right): http://codereview.chromium.org/13014/diff/1/6#newcode325 Line 325: static bool NotWord(uc16 c) { Symmetry suggests NotRegExpWord. http://codereview.chromium.org/13014/diff/1/6#newcode346 Line 346: TestCharacterClassEscapes('.', IsRegExpNewline); Shouldn't this be IsNOTRegExpNewline? http://codereview.chromium.org/13014 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
