lgtm I assume you ran this through the mozilla tests? I know we had trouble finding the right sequence of win32 apis when we did this the first time.
I think the bug the ensure against is that computing the offset for a time which was in DST when we're no longer in DST still works. For instance, set your machine to be US time, in DST. Then run the tests. Then, set your machine to be without DST and run the tests again. http://codereview.chromium.org/12824/diff/201/202 File src/platform-win32.cc (right): http://codereview.chromium.org/12824/diff/201/202#newcode453 Line 453: if (posix_time >= 32535244800i64) return 0; // Jan 1, 3001. _MAX__TIME64_T nit: I find this code unnecessarily compressed; do you mind moving the return statements to a newline? http://codereview.chromium.org/12824 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
