LGTM.
One proposal to make the change even simpler, though.
(Maybe too simple...)


http://codereview.chromium.org/12865/diff/1/2
File benchmarks/base.js (left):

http://codereview.chromium.org/12865/diff/1/2#oldcode123
Line 123: runner.NotifyScore(Math.round(100 * score));
Just wondering if it would make sense to always simply do toPrecision(3)
instead of Math.round here in base.js. Then we would neither need the
formatScore function nor the changes in run.{html,js} files.

http://codereview.chromium.org/12865

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to