http://codereview.chromium.org/10993/diff/1/5 File src/codegen-ia32.cc (right):
http://codereview.chromium.org/10993/diff/1/5#newcode3112 Line 3112: frame_->SpillAll(); Is there a single call to Load in this file that is not followed by a frame_->SpillAll()? You should probably move the mandatory (?) spilling code into the Load function and explain the reason for it in a good fat comment. Style nit: we should use the accessor to get at the frame_ instead of using it directly. http://codereview.chromium.org/10993/diff/1/5#newcode4185 Line 4185: frame->SpillAll(); Could this SpillAll() be moved after the EmitPop(eax)? Then you could potentially materialize the value for eax without having to go through memory and then spill the remainder after EmitPop(). http://codereview.chromium.org/10993/diff/1/5#newcode4200 Line 4200: frame->SpillAll(); ditto. http://codereview.chromium.org/10993 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
