LGTM
http://codereview.chromium.org/13093/diff/1/2 File src/d8-readline.cc (right): http://codereview.chromium.org/13093/diff/1/2#newcode37 Line 37: #if RL_READLINE_VERSION >= 0x0500 I think this deserves a comment. http://codereview.chromium.org/13093/diff/1/5 File src/platform-macos.cc (right): http://codereview.chromium.org/13093/diff/1/5#newcode202 Line 202: if (len < n) Might as well use StrDup for the case where len == n. http://codereview.chromium.org/13093/diff/1/6 File src/platform-win32.cc (right): http://codereview.chromium.org/13093/diff/1/6#newcode698 Line 698: char* OS::StrDup(const char* str) { Wot no strndup? http://codereview.chromium.org/13093 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "v8-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/v8-dev?hl=en -~----------~----~----~----~------~----~------~--~---
