LGTM.
http://codereview.chromium.org/12984/diff/1/2 File src/zone.cc (right): http://codereview.chromium.org/12984/diff/1/2#newcode166 Line 166: int segment_overhead = sizeof(Segment) + kAlignment; This is a constant, right? Maybe make it 'static const int kSegmentOverhead'? http://codereview.chromium.org/12984/diff/1/2#newcode177 Line 177: new_size = RoundUp(size + segment_overhead, kMinimumSegmentSize); Why do you round the result up? If it's a feature to (maybe) leave some room in the new segment, you may want to document that in a comment. http://codereview.chromium.org/12984 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
