Reviewers: Mads Ager, iposva,

Message:
Another option would be some -DUSE_VALGRIND_BLAH, although that ends up
being a pain to propagate through the chromium build...

Description:
Notify valgrind when we modify code in FlushICache.

It's currently fairly slow to run valgrind correctly on v8.  This would
likely improve the performance, but the code is ugly so I'm not very
happy with the idea of it.  I just sort of sent it as a thought, I don't
expect you to want to take it.

You can read more background on the situation here:

http://valgrind.org/docs/manual/manual-core-adv.html#manual-core-adv.clientreq

http://valgrind.org/docs/manual/faq.html#faq.java


Please review this at http://codereview.chromium.org/13612

Affected files:
   M src/cpu-ia32.cc
   A src/third_party/valgrind/valgrind.h



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to