Does it lint?
http://codereview.chromium.org/12900/diff/203/216 File src/jsregexp.cc (right): http://codereview.chromium.org/12900/diff/203/216#newcode1009 Line 1009: // is requested for an identical GenerationVariant. Most excellent! http://codereview.chromium.org/12900/diff/203/216#newcode1205 Line 1205: int max_register, Indentation off. http://codereview.chromium.org/12900/diff/203/216#newcode1298 Line 1298: // Create a new trivial state and generate the node with that. trivial -> empty? http://codereview.chromium.org/12900/diff/203/216#newcode1443 Line 1443: Guard* guard, Indentation. http://codereview.chromium.org/12900/diff/203/216#newcode1599 Line 1599: ranges->at(0).from() == 0 && Maybe add an IsEverything method on CharacterRange to match the CharacterRange::Everything() method that is used to construct most of these. http://codereview.chromium.org/12900/diff/203/209 File src/jsregexp.h (right): http://codereview.chromium.org/12900/diff/203/209#newcode914 Line 914: class GenerationVariant { Not a fan of this name though I can't think of anything better. http://codereview.chromium.org/12900 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
