LGTM with comments.
http://codereview.chromium.org/13618/diff/1/2 File src/jsregexp.cc (right): http://codereview.chromium.org/13618/diff/1/2#newcode315 Line 315: // on JSCRE. We rejoice at the though of the day when this is spolling. http://codereview.chromium.org/13618/diff/1/2#newcode346 Line 346: // on JSCRE. We rejoice at the though of the day when this is Speling http://codereview.chromium.org/13618/diff/1/2#newcode914 Line 914: int char_size = is_ascii ? sizeof(char) : sizeof(uc16); // NOLINT It's part of the definition of the language that sizeof(char) == 1. Also I'd prefer a char_shift of 0 or 1. http://codereview.chromium.org/13618/diff/1/2#newcode935 Line 935: SeqTwoByteString::kHeaderSize - kHeapObjectTag; SeqAsciiString and SeqTwoByteString have methods for this which should be used. http://codereview.chromium.org/13618/diff/1/5 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/13618/diff/1/5#newcode687 Line 687: // This function MUST NOT cause a garbage collection. A GC might move Instead of shouting RFC-style I would prefer 'is not allowed to' http://codereview.chromium.org/13618 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
