LGTM
http://codereview.chromium.org/13244/diff/1/2 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/13244/diff/1/2#newcode666 Line 666: __ lea(eax, Operand(edi, cp_offset)); You can use char_size() to generalize code that only differ on character size, not opcode, without switching on mode: __ lea(eax, Operand(edi, cp_offset * char_size()); http://codereview.chromium.org/13244 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
