My $.02. Lgtm overall.
http://codereview.chromium.org/13341/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/13341/diff/1/2#newcode1973 Line 1973: static void AddObjectGroup(Persistent<Object>* objects, size_t length); This might as well be Persistent<Value>* since the first thing you do is cast it to a i::Object***. Confusingly, v8::Value is equivalent i::Object** whereas v8::Object is equivalent to i::JSObject. http://codereview.chromium.org/13341/diff/1/6 File src/mark-compact.cc (right): http://codereview.chromium.org/13341/diff/1/6#newcode570 Line 570: ObjectGroup* entry = (*object_groups)[i]; You would usually use object_groups->at(i). http://codereview.chromium.org/13341 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
