http://codereview.chromium.org/13343/diff/201/15
File src/jsregexp.cc (right):

http://codereview.chromium.org/13343/diff/201/15#newcode3677
Line 3677: bool has_been_expanded_;
Good point.

http://codereview.chromium.org/13343/diff/201/15#newcode3778
Line 3778: node = new TextNode(new RegExpCharacterClass('*'), node);
Yes, it can use has_lookbehind to determine that.

http://codereview.chromium.org/13343/diff/201/19
File test/cctest/test-regexp.cc (right):

http://codereview.chromium.org/13343/diff/201/19#newcode1295
Line 1295: Execute("\\bboy\\b", false, true, true);
It's really convenient to be able to build this along with the rest of
the code through the build system and run it through the eclipse
debugger.  If it's a problem I can make sure to revert any changes I've
made before committing.

Incidentally, meaningful has only one L.

http://codereview.chromium.org/13343

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to