Lgtm
http://codereview.chromium.org/13784/diff/1/4 File src/parser.cc (right): http://codereview.chromium.org/13784/diff/1/4#newcode530 Line 530: bool IsNonSimple(); You should generally avoid negative method names. How about IsSimple()? http://codereview.chromium.org/13784/diff/1/4#newcode551 Line 551: bool non_simple_; Ditto. http://codereview.chromium.org/13784/diff/1/4#newcode3555 Line 3555: bool RegExpParser::IsNonSimple() { This should be a simple accessor, not a full camel case method. http://codereview.chromium.org/13784 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
