LGTM On Fri, Dec 12, 2008 at 12:38 PM, <[email protected]> wrote:
> Reviewers: Erik Corry, > > Message: > Very quick fix. > TBR. > > Description: > Regexp-IA32 tests doesn't work with snapshots. > > Please review this at http://codereview.chromium.org/13786 > > Affected files: > M test/cctest/test-regexp.cc > > > Index: test/cctest/test-regexp.cc > diff --git a/test/cctest/test-regexp.cc b/test/cctest/test-regexp.cc > index > 4d03b2af54fa094460c03dce5ea22162dd8a82a6..9ce2ee1e88b509ab11435ce600f14d4123bb9ba9 > 100644 > --- a/test/cctest/test-regexp.cc > +++ b/test/cctest/test-regexp.cc > @@ -592,7 +592,7 @@ class ContextInitializer { > > > TEST(MacroAssemblerIA32Success) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 4); > @@ -627,7 +627,7 @@ TEST(MacroAssemblerIA32Success) { > > > TEST(MacroAssemblerIA32Simple) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 4); > @@ -687,7 +687,7 @@ TEST(MacroAssemblerIA32Simple) { > > > TEST(MacroAssemblerIA32SimpleUC16) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::UC16, 4); > @@ -750,7 +750,7 @@ TEST(MacroAssemblerIA32SimpleUC16) { > > > TEST(MacroAssemblerIA32Backtrack) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 0); > @@ -789,7 +789,7 @@ TEST(MacroAssemblerIA32Backtrack) { > > > TEST(MacroAssemblerIA32BackReference) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 3); > @@ -836,7 +836,7 @@ TEST(MacroAssemblerIA32BackReference) { > > > TEST(MacroAssemblerIA32AtStart) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 0); > @@ -897,7 +897,7 @@ TEST(MacroAssemblerIA32AtStart) { > > > TEST(MacroAssemblerIA32BackRefNoCase) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 4); > @@ -955,7 +955,7 @@ TEST(MacroAssemblerIA32BackRefNoCase) { > > > TEST(MacroAssemblerIA32Registers) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 5); > @@ -1056,7 +1056,7 @@ TEST(MacroAssemblerIA32Registers) { > > > TEST(MacroAssemblerIA32StackOverflow) { > - V8::Initialize(NULL); > + v8::V8::Initialize(); > ContextInitializer initializer; > > RegExpMacroAssemblerIA32 m(RegExpMacroAssemblerIA32::ASCII, 0); > > > -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
