LGTM with the sync state bug fixed.
http://codereview.chromium.org/13344/diff/208/12 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/13344/diff/208/12#newcode504 Line 504: !target.reg().is(source.reg())) { As we discussed, the source and targets could be the same register but with different sync states. In that case, the source's sync bit may need to be cleared, or a move generated to set the target's sync bit. http://codereview.chromium.org/13344/diff/208/12#newcode526 Line 526: SyncElementAt(i); It seems better to call sync (which will work on the source register) before changing the reference counts to reflect the transfer. http://codereview.chromium.org/13344 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
