LGTM, with comments

http://codereview.chromium.org/13746/diff/401/410
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/13746/diff/401/410#newcode1226
Line 1226: deferred->BranchTo(not_zero);
Will conflict with my changes, I think

http://codereview.chromium.org/13746/diff/401/405
File src/codegen.cc (right):

http://codereview.chromium.org/13746/diff/401/405#newcode109
Line 109: code->ExitIfBound();
Do we have any deferred code objects that don't return at the end, in
which case this would produce dead code?  Or does JumpTarget::Jump check
for an empty frame?

http://codereview.chromium.org/13746

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to