I looked at the functions involved, and some comments seem wrong. I'm not sure why the names need changing. Raw seems to mean not updating register counts, rather than not checking for space. Can I submit the CL as is?
http://codereview.chromium.org/14158/diff/5/205 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/14158/diff/5/205#newcode169 Line 169: // Clear the dirty bit for the element at a given index. This requires This function only ever writes one dirty element to the frame, so the plural in the comment is misleading. Can be called with 0 <= index <= stack_pointer_ + 1. http://codereview.chromium.org/14158/diff/5/205#newcode258 Line 258: // Make the type of the element at a given index be MEMORY. We can only This comment seems wrong. We can call SpillElementAt on any index in the frame, even above the sp. http://codereview.chromium.org/14158/diff/5/205#newcode270 Line 270: void VirtualFrame::SyncRange(int begin, int end) { I think we have a precondition here, not commented, that begin must be less than or equal to sp + 1. http://codereview.chromium.org/14158 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
