LGTM On Thu, Dec 18, 2008 at 11:37 AM, <[email protected]> wrote: > Reviewers: Mads Ager, > > Description: > Removed tabs from d8.js. > > TBR=ager > > Please review this at http://codereview.chromium.org/14835 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/d8.js > > > Index: src/d8.js > =================================================================== > --- src/d8.js (revision 996) > +++ src/d8.js (working copy) > @@ -179,9 +179,9 @@ > return; > } > > - // Create an underline with a caret pointing to the source position. If > the > - // source contains a tab character the underline will have a tab > character in > - // the same place otherwise the underline will have a space character. > > + // Create an underline with a caret pointing to the source position. If > the > + // source contains a tab character the underline will have a tab > character in > + // the same place otherwise the underline will have a space character. > var underline = ''; > for (var i = 0; i < position; i++) { > if (source_text[i] == '\t') { > @@ -197,7 +197,7 @@ > }; > > > -function FrameSourceUnderline(frame) { > +function FrameSourceUnderline(frame) { > var location = frame.sourceLocation(); > if (location) { > return SourceUnderline(location.sourceText(), > > >
--~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
