I think we actually want to invalidate pushed results (pushing consumes the result). The comments claim we do it but the code doesn't do it. That's fixed and a new version uploaded.
On Thu, Dec 18, 2008 at 4:44 PM, <[email protected]> wrote: > Reviewers: William Hesse, > > Message: > This turns out to be a useful step on the way to handling jump targets > properly. > > Description: > Experimental: use the Result class to manage the lifetime of registers > returned by the register allocator. > > It was simplest to move it to the register allocator source file. > Implemented copy constructor and assignment operator for results. > Some minor cleanup. > > Please review this at http://codereview.chromium.org/15037 > > SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ > > Affected files: > M src/codegen-ia32.cc > M src/register-allocator-ia32.h > M src/register-allocator-ia32.cc > M src/virtual-frame-ia32.h > M src/virtual-frame-ia32.cc > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
