LGTM with some minor comments below.
http://codereview.chromium.org/16481/diff/1/8 File src/codegen-ia32.cc (right): http://codereview.chromium.org/16481/diff/1/8#newcode1212 Line 1212: is_smi.Branch(zero, &right_side, &left_side, taken); It doesn't really matter, but would rather have these passed in the other order. http://codereview.chromium.org/16481/diff/1/8#newcode1230 Line 1230: Result answer = frame_->CallStub(&stub, &right_side, &left_side, 0); Ditto. http://codereview.chromium.org/16481/diff/1/8#newcode1238 Line 1238: // This is currenly sub-optimal, I think. A multiline comment should not begin as an end of line comment. Don't be so personal in the comments and try to be more explicit. The reader doesn't know who the "I" in question is if they want to ask why this is suboptimal. You should probably hint at what's suboptimal here: the slow case frame will be spilled by the call to the stub, which will currently cause the fast case frame to be spilled too. http://codereview.chromium.org/16481/diff/1/3 File src/virtual-frame-ia32.cc (right): http://codereview.chromium.org/16481/diff/1/3#newcode135 Line 135: if (!frame_registers_.is_used(target.code())) return; Use the overloaded version of is_used that takes a Register argument. http://codereview.chromium.org/16481 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
