The virtual frame is a compile-time artifact standing in for an intermediate representation with explicitly named temporaries that are eligible for register allocation. Since we don't really need to allocate cc_reg to a register or spill it to memory, I'm not sure it fits in the frame.
It would be a fairly big change to get right. My preference is to get rid of it (cc_reg and has_cc()) instead. On Tue, Dec 30, 2008 at 4:17 PM, William Hesse <[email protected]> wrote: > Isn't is about time that we make a virtual TOS frame element for CC code in > a flags register?That would affect this code. I think we decided that it > was the right thing to do, rather than the CC flag. > > > On Tue, Dec 30, 2008 at 3:23 PM, <[email protected]> wrote: > >> Reviewers: William Hesse, >> >> Description: >> Experimental: allow register allocation across if statements and empty >> statements. >> >> Please review this at http://codereview.chromium.org/17020 >> >> SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/ >> >> Affected files: >> M src/codegen-ia32.cc >> >> >> > > > -- > We can IMAGINE what is not > > > > --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
