Author: [email protected]
Date: Tue Dec 30 05:49:09 2008
New Revision: 1022

Modified:
    branches/experimental/toiger/src/virtual-frame-ia32.cc

Log:
Experimental: the code to make a frame mergable is sometimes emitted
between an instruction that sets the processor flags and an
instruction that tests them.  The flags must not be affected by the
make mergable code (mov and push is OK, xor is not).
Review URL: http://codereview.chromium.org/17017

Modified: branches/experimental/toiger/src/virtual-frame-ia32.cc
==============================================================================
--- branches/experimental/toiger/src/virtual-frame-ia32.cc      (original)
+++ branches/experimental/toiger/src/virtual-frame-ia32.cc      Tue Dec 30  
05:49:09 2008
@@ -196,7 +196,7 @@
        // Write elements below the stack pointer to their (already  
allocated)
        // actual frame location.
        if (element.is_constant()) {
-        __ Set(Operand(ebp, fp_relative(index)),  
Immediate(element.handle()));
+        __ mov(Operand(ebp, fp_relative(index)),  
Immediate(element.handle()));
        } else {
          ASSERT(element.is_register());
          __ mov(Operand(ebp, fp_relative(index)), element.reg());
@@ -365,7 +365,7 @@
      ASSERT(!target.is_valid() || target.is_register() ||  
target.is_memory());
      if (target.is_register()) {
        if (source.is_constant()) {
-        __ Set(target.reg(), Immediate(source.handle()));
+        __ mov(target.reg(), Immediate(source.handle()));
        } else if (source.is_register() && !source.reg().is(target.reg())) {
          __ mov(target.reg(), source.reg());
        }

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to