One additional comment.
http://codereview.chromium.org/16506/diff/201/403 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/16506/diff/201/403#newcode409 Line 409: bool RegExpMacroAssemblerIA32::CheckSpecialCharacterClass(uc16 type, A lot of unnamed constants are used in this code and it is not obvious to me what is going on. I think each of the cases in the switch should have a comment explaining what is going on. http://codereview.chromium.org/16506 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
