Reviewers: Mads Ager, Description: Fixed double printing of exceptions when enabeling the debugger.
Detect the response to the continue command. Please review this at http://codereview.chromium.org/17071 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/d8.cc M src/d8.js Index: src/d8.js =================================================================== --- src/d8.js (revision 1024) +++ src/d8.js (working copy) @@ -705,9 +705,14 @@ details.text = result; break; + case 'continue': + details.text = "(running)"; + break; + default: details.text = - 'Response for unknown command \'' + response.command + '\''; + 'Response for unknown command \'' + response.command + '\'' + + ' (' + json_response + ')'; } } catch (e) { details.text = 'Error: "' + e + '" formatting response'; Index: src/d8.cc =================================================================== --- src/d8.cc (revision 1024) +++ src/d8.cc (working copy) @@ -106,14 +106,14 @@ Handle<Script> script = Script::Compile(source, name); if (script.IsEmpty()) { // Print errors that happened during compilation. - if (report_exceptions) + if (report_exceptions && !i::FLAG_debugger) ReportException(&try_catch); return false; } else { Handle<Value> result = script->Run(); if (result.IsEmpty()) { // Print errors that happened during execution. - if (report_exceptions) + if (report_exceptions && !i::FLAG_debugger) ReportException(&try_catch); return false; } else { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
