LGTM, with comments.
http://codereview.chromium.org/16512/diff/6/207 File src/codegen-ia32.cc (right): http://codereview.chromium.org/16512/diff/6/207#newcode1677 Line 1677: __ cmp(context.reg(), Operand(esi)); Can't context.Unuse() go directly after the cmp instruction? http://codereview.chromium.org/16512/diff/6/206 File src/virtual-frame-ia32.h (right): http://codereview.chromium.org/16512/diff/6/206#newcode284 Line 284: // Save the value of the esi register in the context frame slot. Comment should say that that esi is not synced to memory until spilled. // Save the esi register to the virtual context frame slot. // The value is not written to memory until synced. Should the code optimize the case where the context slot is already esi? http://codereview.chromium.org/16512 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
