http://codereview.chromium.org/17409/diff/1/4 File src/jsregexp.cc (right):
http://codereview.chromium.org/17409/diff/1/4#newcode3006 Line 3006: if (!has_minimum && Good point, fixed. http://codereview.chromium.org/17409/diff/1/4#newcode3021 Line 3021: // number first and skip the empty check if it's not enough. We should but I'm not quite sure how to do that. We may have to push a backtrack for each of the remaining repetition, if not in practice then at least in effect. http://codereview.chromium.org/17409/diff/1/12 File src/regexp-macro-assembler.h (right): http://codereview.chromium.org/17409/diff/1/12#newcode139 Line 139: // label if it is. Whoops, forgot to update the comment when changing the method. Fixed. http://codereview.chromium.org/17409 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
