LGTM.
http://codereview.chromium.org/17416/diff/245/250 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/17416/diff/245/250#newcode695 Line 695: // stack limit being hit and an exception have already been raised. "an exception has already" http://codereview.chromium.org/17416/diff/245/254 File src/regexp-stack.cc (right): http://codereview.chromium.org/17416/diff/245/254#newcode63 Line 63: size = RoundUpToPowerOf2(size); On 2009/01/09 10:34:58, Erik Corry wrote: > I see no need to round up. On the contrary if we ever move to a growth factor > that is not 2 then it could cause confusion, esp one that is less than 2. Erik has a point here. The sizes do not have to be a power of two as there is no assumption in the code about alignment of this block. http://codereview.chromium.org/17416 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
