Reviewers: Mads Ager, Description: Introducing a kUninitialized constant used for clearing the function cache.
Please review this at http://codereview.chromium.org/17639 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/apinatives.js M src/macros.py Index: src/macros.py =================================================================== --- src/macros.py (revision 1056) +++ src/macros.py (working copy) @@ -61,6 +61,9 @@ const msPerHour = 3600000; const msPerDay = 86400000; +# For apinatives.js +const kUninitialized = -1; + # Note: kDayZeroInJulianDay = ToJulianDay(1970, 0, 1). const kInvalidDate = 'Invalid Date'; const kDayZeroInJulianDay = 2440588; Index: src/apinatives.js =================================================================== --- src/apinatives.js (revision 1056) +++ src/apinatives.js (working copy) @@ -65,7 +65,7 @@ var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset); var isFunctionCached = (serialNumber in cache) && - (cache[serialNumber] != -1); + (cache[serialNumber] != kUninitialized); if (!isFunctionCached) { try { cache[serialNumber] = null; @@ -82,7 +82,7 @@ } ConfigureTemplateInstance(fun, data); } catch (e) { - cache[serialNumber] = -1; + cache[serialNumber] = kUninitialized; throw e; } } --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
