Author: olehougaard
Date: Mon Jan 12 23:37:53 2009
New Revision: 1057

Modified:
    branches/bleeding_edge/src/apinatives.js
    branches/bleeding_edge/src/macros.py

Log:
Introducing a kUninitialized constant used for clearing the function cache.
Review URL: http://codereview.chromium.org/17639

Modified: branches/bleeding_edge/src/apinatives.js
==============================================================================
--- branches/bleeding_edge/src/apinatives.js    (original)
+++ branches/bleeding_edge/src/apinatives.js    Mon Jan 12 23:37:53 2009
@@ -64,8 +64,7 @@
    var cache = kApiFunctionCache;
    var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
    var isFunctionCached =
-   (serialNumber in cache) &&
-   (cache[serialNumber] != -1);
+   (serialNumber in cache) && (cache[serialNumber] != kUninitialized);
    if (!isFunctionCached) {
      try {
        cache[serialNumber] = null;
@@ -82,7 +81,7 @@
        }
        ConfigureTemplateInstance(fun, data);
      } catch (e) {
-      cache[serialNumber] = -1;
+      cache[serialNumber] = kUninitialized;
        throw e;
      }
    }

Modified: branches/bleeding_edge/src/macros.py
==============================================================================
--- branches/bleeding_edge/src/macros.py        (original)
+++ branches/bleeding_edge/src/macros.py        Mon Jan 12 23:37:53 2009
@@ -61,6 +61,9 @@
  const msPerHour        = 3600000;
  const msPerDay         = 86400000;

+# For apinatives.js
+const kUninitialized = -1;
+
  # Note: kDayZeroInJulianDay = ToJulianDay(1970, 0, 1).
  const kInvalidDate        = 'Invalid Date';
  const kDayZeroInJulianDay = 2440588;

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to