LGTM
http://codereview.chromium.org/17376/diff/1/6 File src/serialize.cc (right): http://codereview.chromium.org/17376/diff/1/6#newcode592 Line 592: "StackGuard::address_of_limit()"); RegexpStackGuard? http://codereview.chromium.org/17376/diff/1/2 File test/cctest/test-serialize.cc (right): http://codereview.chromium.org/17376/diff/1/2#newcode112 Line 112: CHECK_EQ(make_code(UNCLASSIFIED, 5), Do you want to have a test for index 4 here as well? http://codereview.chromium.org/17376/diff/1/2#newcode144 Line 144: decoder.Decode(make_code(UNCLASSIFIED, 5))); Ditto. http://codereview.chromium.org/17376 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
