http://codereview.chromium.org/17378/diff/1/4 File src/jsregexp.cc (right):
http://codereview.chromium.org/17378/diff/1/4#newcode1378 Line 1378: assembler->PushRegister(reg, check_stack_limit); I'd like to defer that optimization. http://codereview.chromium.org/17378/diff/1/4#newcode1428 Line 1428: case ActionNode::STORE_POSITION: { Fixed http://codereview.chromium.org/17378/diff/1/4#newcode1438 Line 1438: case ActionNode::CLEAR_CAPTURES: { Fixed http://codereview.chromium.org/17378/diff/1/5 File src/jsregexp.h (right): http://codereview.chromium.org/17378/diff/1/5#newcode717 Line 717: RegExpNode* on_success); Fixed http://codereview.chromium.org/17378/diff/1/5#newcode764 Line 764: int range_from; I thought so too but it turns out that you can't have union members that have a constructor. http://codereview.chromium.org/17378/diff/1/5#newcode1011 Line 1011: bool Mentions(int reg); I'm not sure -- all other operations than the one I added use just one register and it would make that code more cluttered to use intervals there. http://codereview.chromium.org/17378/diff/1/6 File src/regexp-macro-assembler-ia32.cc (right): http://codereview.chromium.org/17378/diff/1/6#newcode932 Line 932: __ mov(register_location(reg), esi); Fixed http://codereview.chromium.org/17378/diff/1/9 File src/regexp-macro-assembler-irregexp.h (right): http://codereview.chromium.org/17378/diff/1/9#newcode69 Line 69: virtual void ClearRegister(int reg); Good point. http://codereview.chromium.org/17378 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
