LGTM. I would be great to run the new compiler through Valgrind at some point to make sure that the virtual frame allocation/deallocation is tight.
http://codereview.chromium.org/18089/diff/1/7 File src/jump-target.h (right): http://codereview.chromium.org/18089/diff/1/7#newcode38 Line 38: // TODO(): Update this comment. You should probably just do this. http://codereview.chromium.org/18089/diff/1/7#newcode102 Line 102: expected_frame_ = NULL; Do we need to delete the expected frame here before setting it to NULL? If not, it should probably be mentioned in a comment. http://codereview.chromium.org/18089/diff/1/7#newcode160 Line 160: void AddReachingFrame(VirtualFrame* frame) { I don't know if this really should be inline. Maybe it would be better to move it to the .cc file? http://codereview.chromium.org/18089 --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
